[LLVMdev] [POLLY] fix Bug 15817

Jack Howarth
Fri, 31 May 2013 18:58:42 -0000

On Fri, May 31, 2013 at 10:48:45AM -0700, Tobias Grosser
wrote:
> On 05/31/2013 06:02 AM, Jack Howarth wrote:
>>     The attached patch eliminates
http://llvm.org/bugs/show_bug.cgi?id=15817 by removing the remaining
>> "; XFAIL:*" added in
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20130415/171812.html.
>> The Isl/CodeGen/scevcodegen-1.ll testcase in polly appears as an XPASS
in current llvm/polly 3.3
>> and trunk svn for both x86_64-apple-darwin* and x86_64 Fedora 15 when
built against isl 0.11.1/2 and
>> cloog 0.18.0. The attached patch eliminates this unexpected XPASS seen
with newer isl/cloog.
>>               Jack
>
> Hi Jack,
>
> the problem was that the failure only occurred when compiled without
> asserts. So just removing the XFAIL does cause troubles on builds with
> asserts enabled. I tightened the test case in r183025 such that it
> should now behave as expected on asserts and non-asserts builds.
>
> Thanks again for reporting and looking into this.

Tobias,
   Can you backport that fix to the polly 3.3 release branch as well?
Thanks in advance.
            Jack

>
> Cheers,
> Tobias