[LLVMdev] [cfe-dev] OpenMP support in CLANG: A proposal

Eli Friedman
Fri, 12 Oct 2012 23:44:29 -0000

On Wed, Oct 10, 2012 at 6:15 AM, Mahesha HS <mahesha.llvm at gmail.com>
wrote:
> Hi Eli and Others
>
> In response to your feedback, I have taken care of all your review comments
> - I removed clangOMP.a
> and moved the implementation of "class OmpPragmaHandler" to
"clangLex.a".
>
> The attached zipped file - namely -
'OpenMP_support_in_Clang.tar.gz'
> contains all the implemented
> "patches" along with *newly* added source files.
>
> Another attached text file - namely -
'OpenMP_support_in_Clang_Read_Me.txt'
> briefly describes the
> implementation.
>
> You can also refer to the initial proposal document - namely -
> 'OpenMP_Support_in_Clang.pdf'.
>
> Looking forward for your review comments.

Can you please split this patch somehow?  This is way too big to
easily review.  I'd like to see separate patches for the command-line
option, the pragma handler itself, parsing each pragma, each new AST
node, and semantic analysis for each kind of pragma, with testcases
for every patch.  And the more you can split them, the better to get
through reviews faster.

Please include new files in patches using "svn add"; don't send
new
files separately.

Please look over patches before submitting to make sure you don't
include unnecessary changes to whitespace etc.

-Eli