[LLVMdev] [cfe-dev] Announcement: Phabricator for code reviews

Michael Spencer
2012-10-18T23:05:28Z

On Wed, Oct 17, 2012 at 10:18 AM, Manuel Klimek <klimek at google.com>
wrote:
> Dear LLVM / Clang community,
>
> we'd like to open the use of Phabricator as an optional tool for doing
code
> reviews to a wider audience. Please feel free to start your code reviews by
> following the documentation at http://llvm.org/docs/Phabricator.html.
>
> Note that e-mail is still the reference medium for code reviews. Please let
> me know about any problems with Phabricator or the documentation you find.
>
> Cheers,
> /Manuel
>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>

One minor issue with the patch I just sent out. If you specify a
specific reviewer, it starts the email with Hi, <name>. Which is
weird. In general review requests are to everyone, with specific
people that you know care about the code in question CCed.

- Michael Spencer