[LLVMdev] A patch for refine the cmake system and also configure

Gabor Greif
2009-08-27T13:26:08Z

Hi Yonggang!

On Aug 27, 1:02 pm, 罗勇刚(Yonggang Luo)  <luoyongg... at gmail.com>
wrote:
> Because this patch must be applied in one time so that don't broken
> the buildbot system.
> So I just submit the configure and cmake at the same time.
> Also, this patch add two new file
> iterator.h
> and
> DataTypes.h

What do you want to improve exactly? Do you experience
problems?

I have spent a good part of my last day with removing
iterator.h (and friends) and have drawn the ire of some
people against me. It was pretty clear that iterator.h
was a horrible kludge.

Why do you want to put it back?

Cheers,

    Gabor

>
> for the reason that patch doesn't support for svn's rename
mechanics.
> So I just add these two file and doesn't delete the old history files
>
> Because I doesn't get configure working (I am not using Unix or
> Linux), so i doesn't testing configure yet.
> But cmake is working file on win32.
>
> Also I add an module CheckSymbols
> It's a module support for check_type_exists and check_include_exists
and so on.
>
> But I doesn't delete
> iterator.in
> and
> iterator.cmake
> and
> DataTypes.h.cmake
> DataTypes.h.in
>
> Indeed, because those two new file is based on these files.
> So we can using the svnr rename function to trace these files.
>
> By the way
> iterator.h is places at llvm/include/llvm/ADT
>
> and
> DataTypes.h is  placed at llvm/include/llvm/Support
> --
>          此致
> 礼
> 罗勇刚
> Yours
>     sincerely,
> Yonggang Luo
>
>  cleanup_iterator_DataTypes.patch
> 24KViewDownload
>
> _______________________________________________
> LLVM Developers mailing list
> LLVM... at cs.uiuc.edu