[LLVMdev] [PATH] Add sub.ovf/mul.ovf intrinsics

Zoltan Varga
Tue, 09 Dec 2008 21:12:34 -0000

Hi,

  Attached is the final version of the patch, adding the requested
FIXME. If this is ok, can
somebody check it in ?

                                thanks

                                      Zoltan

On Tue, Dec 9, 2008 at 9:58 PM, Bill Wendling <isanbard at gmail.com>
wrote:
> On Tue, Dec 9, 2008 at 6:11 AM, Zoltan Varga <vargaz at gmail.com>
wrote:
>> Hi,
>>
>>  Here is the next iteration of the patch. The only comment not
>> addressed is this one:
>>
> Thanks! It's looking good.
>
>>> It would be better to implement a target-independent check for
>>> overflow for the "Legal" case (like how SADDO does).
Hacker's > Delight
>>> has some hints on how to do this. It's not easy for the signed
case,
>>> but is do-able.
>>
>> It can be lowered to a division + a branch, so it would be
>> inefficient, plus it would
>> be a lot of work to implement it correctly (for me at least).
>>
> Okay. It would be tricky. Please put a "FIXME" in there
indicating
> that it would be nice to have at some point. It's okay to submit this.
>
> -bw
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm-ovf.diff
Type: text/x-diff
Size: 37966 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20081209/cd928d07/attachment.diff>