[LLVMdev] Exception handling in JIT

Duncan Sands
Wed, 12 Dec 2007 12:35:32 -0000

Hi,

> > It does look like it's in need of some refactoring. How much work
is it?
> >
> >
>
> Anton or Duncan may know how much work it should be. DwarfWriter writes
> on a file and only knows about label names, not label addresses. IMO the
> refactoring is non-trivial.

it may be hard, but it is important.  See PR1415.

> >> +  // Sort the landing pads in order of their type ids.  This is
> >> used to fold
> >> +  // duplicate actions.
> >> +  SmallVector<const LandingPadInfo *, 64> LandingPads;
> >> +  LandingPads.reserve(PadInfos.size());
> >> +  for (unsigned i = 0, N = PadInfos.size(); i != N; ++i)
> >> +    LandingPads.push_back(&PadInfos[i]);
> >> +  std::sort(LandingPads.begin(), LandingPads.end(), PadLT);
> >>
> >
> > stable_sort instead? Does it matter?
>
> I leave that to the DwarWriter.cpp coders. All the code here is taken
> from that file.

It doesn't matter.

Ciao,

Duncan.