[LLVMdev] llvm-gcc-4-2 development branch is open

Devang Patel
Thu, 12 Jul 2007 15:54:45 -0000

On Jul 11, 2007, at 7:54 PM, Duncan Sands wrote:

> Hi Devang, thanks very much for doing this.
>
>> 2) I'd appreciate if LLVM specific code is covered by appropriate
>> markers. There are tons of existing examples in current sources.
>> Entire LLVM support patch is covered by these markers. I might have
>> removed code from llvm-gcc-4.0 that was required for LLVM support but
>> was not covered under /* APPLE LOCAL <begin|end> LLVM */ markers.
If
>> someone feels strongly about word APPLE  in these markers then feel
>> free to change **ALL LLVM specific** markers to say /* LLVM LOCAL
>> <begin|end> */.  However, please do not change other markers that
>> carry "APPLE LOCAL" string.
>
> I am in favour of changing markers to "/* LLVM LOCAL <begin|end>
*/".
> Shall I just do it?

Sure. If possible, do it in one check-in.

Chris has already answered other questions.

-
Devang

>> 3) This svn module is for GCC-4.2 based front end for LLVM. Please do
>> not check-in code from FSF GCC mainline (which uses 4.3 as version
>> number). If you need a LLVM front end based on GCC 4.3, please create
>> separate llvm.org/svn/llvm-project/llvm-gcc-4-3 module.
>
> Is back-porting fixes from 4.3 OK?
>
>> 5) There are many GCC tree structure changes that I have not noticed
>> yet.
>
> I think STRING_CONSTANT is actually a constant in 4.2, which means all
> those tests for "is it a constant or a STRING_CONSTANT" in llvm-
> convert
> can be simplified.
>
>> Note, llvm-gcc-4-2 does not replace llvm-gcc-4-0. Current llvm-gcc FE
>> (which is based on GCC-4.0) will be added in llvm svn at llvm.org/
>> svn/
>> llvm-project/llvm-gcc-4-0. I have not picked up llvm-gcc-4-0 check-
>> ins
>> done in last few days in initial llvm-gcc-4-2 checkin.
>
> What to do about new patches to 4.0?  Should we insist that they
> also be
> applied to 4.2, if it makes sense to do so?
>
> Ciao,
>
> Duncan.