[LLVMdev] misc CVS patches

Misha Brukman
Thu, 21 Apr 2005 17:24:01 -0000

On Thu, Apr 21, 2005 at 05:56:43PM +0200, Markus F.X.J. Oberhumer
wrote:
> Reid Spencer wrote:
> >This patch can't be applied. Not all platforms have getgid() and
> >getuid() functions. Placing non-portable code outside of lib/System
> >is deprecated. We set the values to 1000 by default because in
> >general the uid/gid doesn't matter in an archive and the 1000 value
> >gets you to a safe (non-root, non-system) value.
>
> I had thought so, but Misha started using these in ArchiveWriter.cpp.

Whoops.  Mea culpa.  After the lib/System/Unix patches, I was mentally
still in Unix-land (hence all my Unix references).

Thanks for fixing, Reid! :)

--
Misha Brukman :: http://misha.brukman.net :: http://llvm.cs.uiuc.edu