[PATCH net-next 6/8] virtio: introduce packed ring defines

Jason Wang
Thu, 05 Jul 2018 11:30:18 -0000

On 2018?07?05? 04:15, Maxime Coquelin wrote:
>
>
> On 07/03/2018 07:38 AM, Jason Wang wrote:
>> diff --git a/include/uapi/linux/virtio_ring.h
>> b/include/uapi/linux/virtio_ring.h
>> index 6d5d5fa..71c7a46 100644
>> --- a/include/uapi/linux/virtio_ring.h
>> +++ b/include/uapi/linux/virtio_ring.h
>> @@ -43,6 +43,8 @@
>> ? #define VRING_DESC_F_WRITE??? 2
>> ? /* This means the buffer contains a list of buffer descriptors. */
>> ? #define VRING_DESC_F_INDIRECT??? 4
>> +#define VRING_DESC_F_AVAIL????? 7
>> +#define VRING_DESC_F_USED??? 15
>
> For consistency, you may want to make VRING_DESC_F_AVAIL and
> VRING_DESC_F_USED to represent the bit mask and not the bit position,
> as done for VRING_DESC_F_WRITE and VRING_DESC_F_INDIRECT.
>
> Regards,
> Maxime

Yes, Tiwei has the same comment.

Will fix this.

Thanks