[PATCH 1/3] Fix ERROR: trailing statements should be on next line

Michael S. Tsirkin
2017-05-15T02:58:05Z

On Sun, May 14, 2017 at 07:51:28PM +0200, Maciek Fijalkowski
wrote:
> From: Maciej Fijalkowski <macfij7 at wp.pl>
>
> Signed-off-by: Maciej Fijalkowski <macfij7 at wp.pl>

I prefer the original form - ; isn't a full statement.

> ---
>  drivers/net/virtio_net.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 9320d96..f20dfb8 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -217,7 +217,8 @@ static void give_pages(struct receive_queue *rq, struct
page *page)
>  	struct page *end;
>
>  	/* Find end of list, sew whole thing into vi->rq.pages. */
> -	for (end = page; end->private; end = (struct page *)end->private);
> +	for (end = page; end->private; end = (struct page *)end->private)
> +		;
>  	end->private = (unsigned long)rq->pages;
>  	rq->pages = page;
>  }
> --
> 2.4.11