[PATCH 1/3] virtio: Basic implementation of virtio pstore driver

Paolo Bonzini
Fri, 18 Nov 2016 09:45:12 -0000

On 18/11/2016 04:32, Namhyung Kim wrote:
>> In addition, the firmware will need to reserve a few KB of RAM for the
error log
>> address range (I checked a real system and it reserves 8KB).  The first
eight
>> bytes are needed for the record identifier interface, because
there's no such
>> thing as 64-bit I/O ports, and the rest can be used for the actual
buffer.
>
> Is there a limit on the size?  It'd be great if it can use a few MB..

Yes, you can make it customizable.

>>> Also I need to control pstore driver like using bigger buffer,
>>> enabling specific message types and so on if ERST supports.  Is it
>>> possible for ERST to provide such information?
>>
>> It's the normal pstore driver, same as on a real server.  What
exactly do you
>> need?
>
> Well, I don't want to send additional pstore messages to the device if
> it cannot handle them properly - for example, ftrace message should not
> overwrite kmsg dump.  It'd be great if device somehow could expose
> acceptable message types to the driver IMHO.

This is something that you have to do in the usual kernel pstore
infrastructure.  It should not be specific to virtualization.

Paolo

> Btw I prefer using the kvmtool for my kernel work since it's much more
> simpler..