[PATCH] virtio_balloon: drop virtio_balloon_stat_modern

Rusty Russell
Wed, 15 Apr 2015 03:15:03 -0000

Cornelia Huck <cornelia.huck at de.ibm.com>
writes:
> On Tue, 14 Apr 2015 12:01:13 +0200
> "Michael S. Tsirkin" <mst at redhat.com> wrote:
>
>> Looks like we are better off sticking with the misaligned stat struct,
>> to reduce the amount of virtio 1 specific code in balloon.  So
let's do
>> it.
>>
>> Add a detailed comment to reduce the chance people copy this bad
example.
>>
>> This also fixes a bug on BE architectures: tag should use
>> cpu_to_le16, not cpu_to_le32.
>>
>> Acked-by: Cornelia Huck <cornelia.huck at de.ibm.com>
>> Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
>> ---
>>
>> Just reposting so it's easier to apply.
>> Feel free to squash into previous patch if you think it's
>> neater.
>
> +1 for squashing from me. My A-b would also apply to the squashed patch.

Yes, I already squashed.

TBH, I would have squashed the next patches into one too, that simply
got rid of the virtio_device_is_legacy_only() function and all callers.

Thanks,
Rusty.