[PATCH v4 4/6] hw_random: fix unregister race.

Herbert Xu
Mon, 10 Nov 2014 13:47:27 -0000

On Mon, Nov 03, 2014 at 11:56:24PM +0800, Amos Kong
wrote:
>
> @@ -98,6 +99,8 @@ static inline void cleanup_rng(struct kref *kref)
>
>  	if (rng->cleanup)
>  		rng->cleanup(rng);

You need a compiler barrier here to prevent reordering.

> +	rng->cleanup_done = true;

Thanks,
--
Email: Herbert Xu <herbert at gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt