[PATCH 6/6] virtio-scsi: Enable DIF/DIX modes in SCSI host LLD

Nicholas A. Bellinger
2014-04-07T08:56:59Z

On Mon, 2014-04-07 at 11:45 +0300, Michael S. Tsirkin
wrote:
> On Sun, Apr 06, 2014 at 09:32:09PM +0000, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger <nab at linux-iscsi.org>
> >
> > This patch updates virtscsi_probe() to setup necessary Scsi_Host
> > level protection resources. (currently hardcoded to 1)
> >
> > It changes virtscsi_add_cmd() to attach outgoing / incoming
> > protection SGLs preceeding the data payload, and is using the
> > new virtio_scsi_cmd_req_pi->d[oi],pi_niv field to signal
> > to signal to vhost/scsi how many prot_sgs to expect.
> >
> > v3 changes:
> >   - Use VIRTIO_SCSI_F_T10_PI to determine PI or non PI header (Paolo)
> >
> > v2 changes:
> >   - Make protection buffer come before data buffer (Paolo)
> >   - Enable virtio_scsi_cmd_req_pi usage (Paolo)
> >
> > Cc: Paolo Bonzini <pbonzini at redhat.com>
> > Cc: Michael S. Tsirkin <mst at redhat.com>
> > Cc: Martin K. Petersen <martin.petersen at oracle.com>
> > Cc: Christoph Hellwig <hch at lst.de>
> > Cc: Hannes Reinecke <hare at suse.de>
> > Cc: Sagi Grimberg <sagig at dev.mellanox.co.il>
> > Cc: H. Peter Anvin <hpa at zytor.com>
> > Signed-off-by: Nicholas Bellinger <nab at linux-iscsi.org>
>
> OK but we need to document the new interface in the spec
> (and incidentially, this will be useful to verify the assumptions
> made here and on the host side).
> Could you please submit this proposal to the OASIS Virtio TC
> for inclusion into the next spec draft?
> Ideally as a patch against the tex source, but a prose
> description would do as well.

Most certainly.  Please give me a bit to follow up on this, as the next
couple of days are going to be hellishly busy..

> The TC meets on a bi-weekly basis, we should be able to ratify
> this quickly.
>

Aside from that, please consider ACK'ing the vhost specific changes so
these can make it into v3.15-rc1 code.

--nab