[PATCH] virtio-spec: add field for scsi command size

Michael S. Tsirkin
2013-06-13T08:10:47Z

On Thu, Jun 13, 2013 at 11:02:59AM +0300, Michael S. Tsirkin
wrote:
> On Thu, Jun 13, 2013 at 02:12:22PM +0930, Rusty Russell wrote:
> > "Michael S. Tsirkin" <mst at redhat.com> writes:
> > > On Thu, Mar 14, 2013 at 04:15:28PM +0100, Paolo Bonzini wrote:
> > >> Il 14/03/2013 12:10, Michael S. Tsirkin ha scritto:
> > >> > Add field for guest to specify command size for
virtio-blk.
> > >> >
> > >> > Signed-off-by: Michael S. Tsirkin <mst at
redhat.com>
> > >
> > > OK, but Rusty usually tweaks wording anyway.
> > > Rusty want to apply and make changes Paolo suggested yourself
> > > or want me to?
> >
> > (MST drew my attention back to this)
> >
> > Please do.  And please add a note about this feature: that without it,
> > the descriptor layout must be on the right boundaries for historical
> > reasons.
>
> It's there already, isn't it:
>
>  If VIRTIO_BLK_F_SCSI_CMD_SIZE is not negotiated,
>  This field must reside in a single, separate read-only buffer;
>  the command length
>  can be derived from the length of this buffer.
>

Wait, I think I got it: you actually want to rename this
VIRTIO_BLK_F_ANY_SG and have it affect all requests?

>
>
> > Thanks,
> > Rusty.