[PATCHv3 vringh] caif_virtio: Introduce caif over virtio

Ohad Ben-Cohen
Sun, 17 Mar 2013 22:52:19 -0000

Hi Erwan,

On Fri, Mar 15, 2013 at 11:42 AM, Erwan Yvin <erwan.yvin at
stericsson.com> wrote:
> diff --git a/drivers/net/caif/caif_virtio.c
b/drivers/net/caif/caif_virtio.c
> new file mode 100644
> index 0000000..6a745dd
> --- /dev/null
> +++ b/drivers/net/caif/caif_virtio.c
> @@ -0,0 +1,786 @@
> +/*
> + * Copyright (C) ST-Ericsson AB 2013
> + * Authors: Vicram Arv / vikram.arv at stericsson.com,
> + *         Dmitry Tarnyagin / dmitry.tarnyagin at stericsson.com
> + *         Sjur Brendeland / sjur.brandeland at stericsson.com
> + * License terms: GNU General Public License (GPL) version 2
> + */
> +#include <linux/module.h>
> +#include <linux/if_arp.h>
> +#include <linux/virtio.h>
> +#include <linux/vringh.h>
> +#include <linux/debugfs.h>
> +#include <linux/spinlock.h>
> +#include <linux/genalloc.h>
> +#include <linux/interrupt.h>
> +#include <linux/netdevice.h>
> +#include <linux/rtnetlink.h>
> +#include <linux/remoteproc.h>

The driver looks nicely decoupled from remoteproc - do you still need
remoteproc.h ?

Thanks,
Ohad.