Signed bit field; int have_hotplug_status_watch:1

Ian Campbell
Mon, 04 Apr 2011 08:26:24 -0000

On Sun, 2011-04-03 at 22:32 +0100, Dr. David Alan Gilbert
wrote:
> Hi Ian,
>    I've been going through some sparse scans of the kernel and
> it threw up:
>
>   CHECK   drivers/net/xen-netback/xenbus.c
> drivers/net/xen-netback/xenbus.c:29:40: error: dubious one-bit signed
bitfield
>
>         int have_hotplug_status_watch:1;
>
> from your patch f942dc2552b8bfdee607be867b12a8971bb9cd85
>
> It does look like that should be an unsigned (given it's assigned
> 0 and 1)

I agree.

8<----------------------------------