Libguestfs - Jul 2023 - Intermittent test failure in guestfs-tools test-virt-filesystems.sh

(See attachment for full log)

https://github.com/rwmjones/guestfs-tools/blob/master/cat/test-virt-filesystems.sh

This test uses virt-filesystems to list the filesystems in the Fedora
phony disk image.  In one run of this test it found an "extra"
/dev/sdb2 filesystem that obviously doesn't exist.

Note that the log contains two runs of virt-filesystems, only the
second one shows a failure.

In the log we see that the appliance has two disks, sda is the
appliance root, sdb is the Fedora image.  Device name translation will
map these two disks in reverse so to virt-filesystems the Fedora image
should appear as /dev/sda and the partitions as /dev/sda{1,2}.

The problem seems to be with the call to guestfs_pvs_full which
returns:

<struct guestfs_lvm_pv_list(1)   [0]{pv_name: /dev/sdb2,         
<--------------------
      pv_uuid: RVgEshd4X91jq8omUQIsB77eyB9miZzL,
      pv_fmt: lvm2,
      pv_size: 532676608,
      dev_size: 536838656,
      pv_free: 130023424,
      pv_used: 402653184,
      pv_attr: a--,
      pv_pe_count: 127,
      pv_pe_alloc_count: 96,
      pv_tags: ,
      pe_start: 1048576,
      pv_mda_count: 1,
      pv_mda_free: 519168, }>

Note that the pv_name returned to virt-filesystems is not reverse
translated, so it returns the appliance name (/dev/sdb2) not the
translated name (/dev/sda2) of the partition containing the Fedora PV.

I will try for a patch which does reverse translation on this field.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top
-------------- next part --------------
A non-text attachment was scrubbed...
Name: build.log.xz
Type: application/x-xz
Size: 24152 bytes
Desc: not available
URL:
<http://listman.redhat.com/archives/libguestfs/attachments/20230720/284d051e/attachment.xz>