[Libguestfs] [PATCH libnbd v2] README: Document additional packages

Richard W.M. Jones
2023-04-17T21:41:57Z

On Mon, Apr 17, 2023 at 07:44:31PM +0300, Nir Soffer
wrote:
> When building from git we need autoconf, automake and libtool.
>
> Signed-off-by: Nir Soffer <nsoffer at redhat.com>
> ---
>
> Changes sinve v1:
> - Remove `,` between package namses (Laszlo)
>
>  README.md | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/README.md b/README.md
> index c7166613..7eed0e31 100644
> --- a/README.md
> +++ b/README.md
> @@ -32,10 +32,17 @@ ## License
>  very liberal license.
>
>
>  ## Building from source
>
> +Building from source requires additional packages. On rpm based system
> +use:
> +
> +```
> +dnf install autoconf automake libtool
> +```
> +
>  To build from git:

No, if we're going to add something (which we probably should) then we
should also describe how to use 'dnf builddep' or the equivalent apt
command.  The command above seems to suggest that you'd only need to
run that 'dnf install ...' which is wrong.

I can add something to the README later if you put a note in TODO.

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org