[Libguestfs] [libnbd PATCH 2/2] debug: Trace even may_set_error=false functions

Richard W.M. Jones
Sun, 04 Sep 2022 16:44:33 -0000

So my feeling about this patch series:

I don't understand why the first patch is necessary, _and_ I think it
might be "dangerous" (for small values of dangerous).

What happens if in future we add a new RStaticString API which returns
a string that does need to be escaped?  It should at least be
documented that RStaticString must only return simple, printable
strings.  But ideally the first patch wouldn't exist and we could deal
with any RStaticString API.

Second patch is completely fine.

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.