[Libguestfs] [libnbd PATCH 1/4] internal: Track traffic stats

Richard W.M. Jones
Sat, 03 Sep 2022 16:25:11 -0000

On Fri, Sep 02, 2022 at 05:14:22PM -0500, Eric Blake
wrote:
>  #ifdef DUMP_PACKETS
> -  if (h->rbuf != NULL)
> -    nbd_internal_hexdump (h->rbuf, r, stderr);
> +  nbd_internal_hexdump (h->rbuf, r, stderr);

Should this be a separate patch?  I guess the assertion here is that
h->rbuf is set to an address earlier in the function so it can never
be NULL.

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch