[Libguestfs] [v2v PATCH] convert/linux_kernels: fix virtio-socket check

Laszlo Ersek
Fri, 01 Apr 2022 10:31:38 -0000

On 03/31/22 15:16, Richard W.M. Jones wrote:
> On Thu, Mar 31, 2022 at 12:57:39PM +0200, Laszlo Ersek wrote:
>> The virtio-vsock support check from commit 05f780c16f01 ("v2v:
support
>> configuration of viosock driver", 2021-02-26) is wrong; it looks
for one
>> of two things:
>> - a module called "virtio_socket",
>> - a kernel config item called VIRTIO_SOCKET.
>>
>> In reality, we need:
>> - the "vmw_vsock_virtio_transport" module,
>> - or the kernel config item VIRTIO_VSOCKETS.
>>
>> Refer to Linux commit 304ba62fd4e6 ("VSOCK: Add Makefile and
Kconfig",
>> 2016-08-02).
>>
>> Fix the parameters of the related "kernel_supports" call.
>>
>> The same virt-v2v commit also missed extending the
"print_kernel_info"
>> function; do that now as well.

> Reviewed-by: Richard W.M. Jones <rjones at redhat.com>

Commit 482e74bb56a6.

Thanks!
Laszlo