[Libguestfs] [PATCH nbdkit 2/2] common/include/checked-overflow.h: Provide fallback

Richard W.M. Jones
Mon, 22 Nov 2021 22:31:42 -0000

(Catching up ...)

The maths looked reasonable.  Did you have a version of the patch for
review?

My only other thought is that a simple set of tests could be good.
However it's not worth having tests that only test if __builtin*
functions are correct (hopefully GCC is already testing that).  So
tests would have to check the fallback macros are correct, even if
they are not used on the current platform.

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org