Re: [Libguestfs] [nbdkit PATCH v2 2/8] api: Add nbdkit_add_default_export

Richard W.M. Jones
Tue, 01 Sep 2020 14:19:11 -0000

On Thu, Aug 27, 2020 at 07:55:48AM -0500, Eric Blake
wrote:
> So I definitely need to respin the doc portion of the patch.
>
> In my usage, I never mixed add_export and add_default_export in the
> same control path (it was one or the other), but I also didn't see a
> problem with a plugin that wants to include its default name in
> addition to other names.
>
> Would bike-shedding the name help, maybe nbdkit_use_default_export,
> to make it obvious that this is instructing nbdkit to reuse
> .default_export?

Yes I think a different name would help here, and the documentation
definitely needs to be updated because I'm very confused by all of
this.

(Also it might have been better if NBD had stuck with "" always
meaning "the default export", but here we are ...)

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.