Re: [Libguestfs] [nbdkit PATCH 5/5] sh, eval: Implement .default_export

Richard W.M. Jones
2020-08-25T19:26:37Z

I think patches 1, 2 and 5 are fine.  It might be an idea to update
the ASCII art in docs/nbdkit-plugin.pod in patch 1.

Patches 3 and 4 are OK if you're happy with them but I have
reservations about the lifetime and design of nbdkit_string_intern and
maybe we should talk about that a bit more.

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.