Re: [Libguestfs] [PATCH 1/3] nbdkit: fix build of the SSH plugin on FreeBSD

Eric Blake
Fri, 19 Jun 2020 15:16:34 -0000

On 6/18/20 8:58 PM, asomers@gmail.com wrote:
> From: Alan Somers <asomers@gmail.com>
>
> There was a missing #include.  It only worked on Linux due to header
> pollution.
> ---
>   plugins/ssh/ssh.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/plugins/ssh/ssh.c b/plugins/ssh/ssh.c
> index ea199a93..a4007c40 100644
> --- a/plugins/ssh/ssh.c
> +++ b/plugins/ssh/ssh.c
> @@ -30,6 +30,8 @@
>    * SUCH DAMAGE.
>    */
>
> +#include <sys/stat.h>
> +
>   #include <config.h>

<config.h> must always be first, as there are cases where it sets macros
that control how system headers will behave.  But I see Rich made that
change.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org