Re: [Libguestfs] [PATCH nbdkit 5/9] todo: Add some other places where the vector.h header could be used.

Eric Blake
Wed, 15 Apr 2020 20:29:21 -0000

On 4/15/20 11:16 AM, Richard W.M. Jones wrote:
> ---
>   TODO | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/TODO b/TODO
> index 25b48498..c4a1625b 100644
> --- a/TODO
> +++ b/TODO
> @@ -98,6 +98,14 @@ General ideas for improvements
>
>   * Examine other fuzzers: https://gitlab.com/akihe/radamsa
>
> +* common/include/vector.h could be extended and used in other places:
> +  - there are some more possible places in the server (anywhere using
> +    realloc is suspect)
> +  - nbdkit-vddk-plugin, where it builds the new argv
> +  - allow insertion, and use it in nbdkit-extentlist-filter
> +  - allow insertion and keep sorted, use it in nbdkit-eval-plugin
> +  - same, and use it in common/sparse/sparse.c

ACK, along with any other ideas we've brought up (such as an iterator
allowing short-circuiting by returning a value, or ...). Or if you
actually write some of those patches before committing the TODO change...

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org