Re: [Libguestfs] [nbdkit PATCH v7 2/2] vddk: Drive library loading from libdir parameter.

Eric Blake
Tue, 18 Feb 2020 17:11:12 -0000

On 2/18/20 11:05 AM, Eric Blake wrote:
> From: "Richard W.M. Jones" <rjones@redhat.com>
>
> Do not use LD_LIBRARY_PATH to locate the VDDK library.  Setting this
> always causes problems because VDDK comes bundled with broken
> replacements for system libraries, such as libcrypto.so and
> libstdc++.so.  Two problems this causes which we have seen in the real
> world:
>

> @@ -406,7 +446,7 @@ vddk_config_complete (void)
>       char *env = getenv ("LD_LIBRARY_PATH");
>
>       nbdkit_debug ("cleaning up after re-exec");
> -    if (!env || strstr (env, reexeced) != 0 ||
> +    if (!env || strstr (env, reexeced) == NULL ||

Oops, this line needs to be squashed in 1/2.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org