[Libguestfs] [nbdkit PATCH 0/2] Make client fallback testing easier

Eric Blake
Thu, 12 Sep 2019 02:46:00 -0000

This is similar to the recent --no-sr option - it's a change that is
unlikely to ever be used except by someone testing whether a client is
compliant to the protocol, but in that niche case, it can be quite
handy (it's a lot nicer to be able to purposefully cripple a server
from the command line than from a one-off compile, when testing if a
client's fallback for a spec-compliant but older server is correct).

I'm planning on writing a counterpart patch for libnbd to allow the
user to mask out bits that the client does not reply with (so you can
choose to cripple the protocol from either the server or the client
side, to see how the other side reacts, similar to the recently-added
nbd_set_request_structured_replies).

I'm open to naming suggestions on the command-line option.

Eric Blake (2):
  server: Skip option haggling from client lacking fixed newstyle
  server: Add --mask-handshake option for integration testing

 docs/nbdkit-protocol.pod             | 25 ++++++++++++++++++-----
 docs/synopsis.txt                    |  2 +-
 server/internal.h                    |  1 +
 server/options.h                     |  2 ++
 server/main.c                        | 30 ++++++++++++++++++----------
 server/protocol-handshake-newstyle.c | 14 +++++++++++--
 6 files changed, 55 insertions(+), 19 deletions(-)

--
2.21.0