Re: [Libguestfs] [PATCH libnbd] api: New nbd_kill_command API for sending a signal to the command subprocess.

Richard W.M. Jones
Thu, 25 Jul 2019 21:11:14 -0000

On Thu, Jul 25, 2019 at 03:19:23PM -0500, Eric Blake
wrote:
> This looks a bit funny until I read the docs at [1].  When using
> kill(2), I'm used to the function call 'kill(pid, 0)' probing
for
> process existence.  But on the command line, kill(1) has the behavior of
> sending SIGTERM by default when you omit a signal number (and not
> serving as a process existence probe).

The reason for this choice is that in some language bindings we might
not have the SIG* symbols available, but there ought to still be a way
to send a default.  Hopefully people will read the docs :-)

I pushed it with s/signal/signum/.

Are we waiting on any other ABI breaks or would now be a good time to
do another 0.x release?

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.