Re: [Libguestfs] [nbdkit PATCH] protocol: Trivially implement NBD_CMD_FLAG_DF

Richard W.M. Jones
2019-03-29T13:49:50Z

On Fri, Mar 29, 2019 at 12:43:33PM +0000, Richard W.M. Jones
wrote:
> On Thu, Mar 28, 2019 at 10:44:42PM -0500, Eric Blake wrote:
> > The DF flag is only available to clients that negotiated structured
> > replies, and even then, the spec does not require that it be
> > implemented. However, since our current implementation can't
fragment
> > NBD_CMD_READ replies, we trivially implement the flag (by ignoring
> > it); we don't even have to pass it on to the plugins.
> >
> > Enhance some documentation about sparse reads while at it (when we
> > finally do allow plugins to implement sparse reads, we'll have to
pass
> > on the DF flag, as well as perform reassembly back into one reply
> > ourselves if the plugin ignored the flag).
> >
> > tests/test-eflags.sh can't really test this, as it requires the
> > negotiation of structured replies (which in turn requires newstyle,
> > not oldstyle...)
> >
> > Signed-off-by: Eric Blake <eblake@redhat.com>
>
> Looks good to me, so ACK.

I have pushed this because I want to do another release containing the
bug fixes from the past few days.

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.