Re: [Libguestfs] [PATCH] lib: Reset errno to zero to avoid erroneously returning E2BIG

Richard W.M. Jones
Tue, 22 Jan 2019 22:21:54 -0000

On Tue, Jan 22, 2019 at 04:43:31PM -0500, Michael Meyer
wrote:
> This line was accidentally removed in 77fe74fc, causing
> bug #1145056 (Bugzilla) to resurface.
> ---
>  lib/utf16.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/utf16.c b/lib/utf16.c
> index e099548..67fa996 100644
> --- a/lib/utf16.c
> +++ b/lib/utf16.c
> @@ -58,6 +58,7 @@ _hivex_recode (hive_h *h, recode_type t,
>        /* Reset errno here because we don't want to accidentally
>         * return E2BIG to a library caller.
>         */
> +      errno = 0;
>        size_t prev = outalloc;
>        /* Try again with a larger output buffer. */
>        free (out);

Sorry about that.  I've pushed your fix now.

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.