Re: [Libguestfs] [PATCH v2 2/2] p2v: add a Shutdown action (RHBZ#1642044)

Richard W.M. Jones
Tue, 06 Nov 2018 13:07:51 -0000

On Tue, Nov 06, 2018 at 12:51:30PM +0100, Pino Toscano
wrote:
> +static void
> +shutdown_clicked (GtkWidget *w, gpointer data)
> +{
> +  if (!is_iso_environment)
> +    return;
> +
> +  sync ();
> +  sleep (2);
> +  ignore_value (system ("/sbin/shutdown now"));
> +}

I've tested this and it works but of course it doesn't in fact power
off the machine.  Would it be better to run "/sbin/poweroff" instead?

Anyway, either way ACK series, thanks.

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.