Re: [Libguestfs] [PATCH v3 1/4] mltools: Rename Yajl module as JSON_parser and move to common/mltools.

Richard W.M. Jones
Fri, 17 Aug 2018 15:48:16 -0000

On Fri, Aug 17, 2018 at 10:30:35AM -0500, Eric Blake
wrote:
> On 08/17/2018 10:16 AM, Richard W.M. Jones wrote:
> >Commit bd1c5c9f4dcf38458099db8a0bf4659a07ef055d changed all the code
> >to use Jansson instead of yajl.  However it didn't change the OCaml
> >API name (which was still Yajl).
> >
>
> Are you aware that Jansson can't parse all JSON generated by qemu,
> and that the developers of Jansson did not seem sympathetic to
> patches that would make it possible?  Libvirt recently reverted
> their use of Jansson because of its inability to deal with unsigned
> 64-bit numbers (and sadly, RFC7159 does not define bounds for what
> forms valid JSON numbers, but merely leaves it up to implementations
> to decide for themselves).

Yes, painfully aware.  Not sure what to do about it however, since the
alternative (ie. switching back to yajl) as libvirt did is not going
to be pleasant.

Currently we're OK as long as disk sizes don't exceed 8 petabytes, if
my quick calculation is correct.

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.