Re: [Libguestfs] [PATCH 1/2] v2v: rhv-upload-plugin: Handle send send failures

Richard W.M. Jones
2018-08-21T11:02:07Z

On Tue, Aug 21, 2018 at 01:15:02AM +0300, Nir Soffer
wrote:
> The oVirt server may fail a PUT request before reading all request body.
> However before closing the connection, it writes a detailed error
> response, that will make debugging issues like expired tickets much
> easier to handle. If we don't get the response and log the error, the
> error may be lost when the daemon log is rotated.

This series looks fine, I'll push it in a minute.

Couple of questions:

(1) Are we using the nbdkit enhanced Python error reporting yet?
What's stopping us if we are not?

(2) Is there a BZ associated with this change?  If not, we'll need one
if you want to get these changes into RHEL.

Thanks,

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.