Re: [Libguestfs] [PATCH] v2v: -o rhv-upload: Optimize http request sending

Tomáš Golembiovský
Thu, 14 Jun 2018 23:56:36 -0000

On Thu, 14 Jun 2018 21:16:01 +0300
Nir Soffer <nirsof@gmail.com> wrote:

> When sending request with small or no payload, it is simpler and
> possibly more efficient to use the high level HTTPSConnection.request(),
> instead of the lower level APIs.
>
> The only reason to use the lower level APIs is to avoid copying the
> payload, or on python 2, to use a bigger buffer size when streaming a
> file-like object.
> ---
>  v2v/rhv-upload-plugin.py | 35 ++++++++++++++++-------------------
>  1 file changed, 16 insertions(+), 19 deletions(-)

FWIW LGTM