Re: [Libguestfs] [nbdkit PATCH v2 2/5] python: Expose can_zero callback

Richard W.M. Jones
2018-04-19T17:23:01Z

On Wed, Apr 11, 2018 at 12:03:39AM -0500, Eric Blake
wrote:
> Fairly straightforward, as the code in plugins.c already takes
> care of necessary .pwrite fallbacks.
>
> Simplify similar can_FOO callbacks that were copy-and-pasted while
> implementing py_can_zero.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  plugins/python/nbdkit-python-plugin.pod |  7 +++++
>  plugins/python/python.c                 | 51
+++++++++++++++++++--------------
>  tests/test.py                           |  4 +++
>  3 files changed, 41 insertions(+), 21 deletions(-)

Straightforward, so ACK.

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.