Re: [Libguestfs] [PATCH] v2v: remove MAC address related information

Tomáš Golembiovský
2018-02-27T12:34:21Z

On Tue, 27 Feb 2018 12:53:08 +0100
Pino Toscano <ptoscano@redhat.com> wrote:

> On Tuesday, 27 February 2018 12:35:36 CET Tomáš Golembiovský wrote:
> > Remove ties to MAC address because it is likely to change.
>
> v2v tries to preserve the MAC address of network interfaces; few months
> ago we did a fix regarding this:
> https://bugzilla.redhat.com/show_bug.cgi?id=1506572
>
> The approach of this patch is IMHO not good, since it removes the MAC
> address from the network-scripts, but still the rest of v2v will try
> to preserve the MAC addresses.
>
> What's the reason behind this patch?

Reason is that the MAC address is likely to change after the conversion
because the environment uses different MAC prefix. It depends on the
management system. For example the default pool in oVirt has prefix
00:1A:4A:... registered to Qumranet Inc. I don't know what VMware has as
as default. Big companies probably have their own prefix and thus are
OK.

Sure, you can have custom MAC addresses with different prefix on your
network. I can't say if that is good idea or bad idea.

It seems to me that this dual approach is right thing to do. Remove the
reference from guest so it is ready for new MAC, but leave the old MAC
in metadata. That way the management system can decide what is the right
way to do.


    Tomas

--
Tomáš Golembiovský <tgolembi@redhat.com>