Re: [Libguestfs] [nbdkit PATCH] plugin: add and use nbdkit_realpath

Eric Blake
2018-02-14T14:29:39Z

On 02/13/2018 09:44 AM, Pino Toscano wrote:
> Introduce a new helper function to resolve a path name, calling
> nbdkit_error on failure: other than doing what nbdkit_absolute_path
> does, it also checks that the file exist (and thus avoid errors later

s/exist/exists/
s/avoid/avoids/

> on).
>
> Apply it where an existing path is required, both in nbdkit itself and
> in plugins.
>
> Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1527334
> ---
>   docs/nbdkit-plugin.pod      | 13 +++++++++++++
>   include/nbdkit-common.h     |  1 +

Should we also document the helper functions in docs/nbdkit-filter.pod?

Otherwise looks good to me

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org