Re: [Libguestfs] [nbdkit PATCH] plugin: add and use nbdkit_realpath

Pino Toscano
2018-02-14T15:37:30Z

On Wednesday, 14 February 2018 15:29:39 CET Eric Blake
wrote:
> On 02/13/2018 09:44 AM, Pino Toscano wrote:
> > Introduce a new helper function to resolve a path name, calling
> > nbdkit_error on failure: other than doing what nbdkit_absolute_path
> > does, it also checks that the file exist (and thus avoid errors later
>
> s/exist/exists/
> s/avoid/avoids/

Fixed locally, thanks.

> > on).
> >
> > Apply it where an existing path is required, both in nbdkit itself and
> > in plugins.
> >
> > Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1527334
> > ---
> >   docs/nbdkit-plugin.pod      | 13 +++++++++++++
> >   include/nbdkit-common.h     |  1 +
>
> Should we also document the helper functions in docs/nbdkit-filter.pod?

If so, that will be a different patch though, since nbdkit-filter does
not document the plugin API, but links to it.

--
Pino Toscano