Re: [Libguestfs] [nbdkit PATCH] tests: test-single: create the fake disk

Richard W.M. Jones
2018-01-31T15:35:34Z

On Wed, Jan 31, 2018 at 04:24:05PM +0100, Pino Toscano
wrote:
> Make sure the fake disk exist, otherwise nbdkit fails.  Also, give the
> fake disk a less generic file name.

The fix is fine but this description is wrong.

The actual problem is you don't have guestfish installed, which is
required to build ‘disk’.  However ‘test-single.sh’ is outside the
automake conditional for HAVE_GUESTFISH, so the test can run without
‘disk’ having been created.

ACK, but with the description fixed to reflect what's really going on.

There may be other tests which are similarly broken, I didn't check.

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org