Re: [Libguestfs] [nbdkit PATCH] tests: test-single: create the fake disk

Pino Toscano
2018-01-31T15:43:16Z

On Wednesday, 31 January 2018 16:35:34 CET Richard W.M. Jones
wrote:
> On Wed, Jan 31, 2018 at 04:24:05PM +0100, Pino Toscano wrote:
> > Make sure the fake disk exist, otherwise nbdkit fails.  Also, give the
> > fake disk a less generic file name.
>
> The fix is fine but this description is wrong.
>
> The actual problem is you don't have guestfish installed, which is
> required to build ‘disk’.  However ‘test-single.sh’ is outside the
> automake conditional for HAVE_GUESTFISH, so the test can run without
> ‘disk’ having been created.

Yes, I discovered that right after sending the patch.

> ACK, but with the description fixed to reflect what's really going on.

What about the following commit message:

"tests: test-single: use an own fake disk

Instead of rely on the disk created as test data in the Makefile, use
a simple fake disk created inside the test itself.  This fixes
test-single.sh when at least one between gzip and guestfish was not
found."

Thanks,
--
Pino Toscano