Re: [Libguestfs] [PATCH] bash: Add a bash completion script for virt-v2v-copy-to-local (RHBZ#1367738).

Richard W.M. Jones
Wed, 22 Mar 2017 15:53:25 -0000

On Wed, Mar 22, 2017 at 11:39:58AM +0100, Pino Toscano
wrote:
> On Wednesday, 22 March 2017 11:30:59 CET Richard W.M. Jones wrote:
> > Thanks: Ming Xie
> > ---
>
> It does not wrong to me, although couldn't an existing completion be
> used for virt-v2v-copy-to-local as well?

We might have used the 'virt-alignment-scan' one (used by all the
other virt-* tools except virt-v2v), but it is considerably more
complicated than needed for this tool.  As far as I could see there is
no completion function which just completes short and long options
with no other magic.  Perhaps one is needed, and perhaps this is the
one!

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.