Re: [Libguestfs] [PATCH v4 0/9] Introducing virt-builder-repository

Pino Toscano
Thu, 09 Mar 2017 17:41:30 -0000

On Tuesday, 7 March 2017 15:26:56 CET Cédric Bosdonnat
wrote:
> Hi all,
>
> Here is a v4 of my series. It includes the changes according to
> Pino and Richard's comments.
>
> However, the perrorf/debug problem is addressed differently:
> instead of adding an implementation for the internal function
> names when building for mllib, I redefine these macros. Obviously
> this is not perfect, but at least easier to understand.
>
> Pino's comment about the Notes regex wasn't quite right... thus
> I added a unit test for the Index_parser.write_entry
>
> As some more code has been moved around, the number of commits
> in the series increased a little bit ;)

I reviewed so far patches 1-8, and they LGTM except where I left
comments.

I left few comments for patch 9 -- I will continue reviewing it
tomorrow.

Thanks,
--
Pino Toscano