Re: [Libguestfs] [PATCH 07/11] tail: pass the right path for Windows guests

Richard W.M. Jones
Fri, 03 Mar 2017 15:10:06 -0000

On Fri, Mar 03, 2017 at 03:33:01PM +0100, Pino Toscano
wrote:
> Call windows_path with the actual path to resolve, instead of a null
> pointer ('filename' is still null at that point), so Windows paths
can
> be properly resolved.
> ---
>  cat/tail.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cat/tail.c b/cat/tail.c
> index 8785d45..51da5fc 100644
> --- a/cat/tail.c
> +++ b/cat/tail.c
> @@ -309,7 +309,7 @@ do_tail (int argc, char *argv[], /* list of files in
the guest */
>        CLEANUP_FREE_STATNS struct guestfs_statns *stat = NULL;
>
>        if (windows) {
> -        filename = windows_path (g, root, filename, 1 /* readonly */);
> +        filename = windows_path (g, root, argv[i], 1 /* readonly */);
>          if (filename == NULL)
>            return -1; /* windows_path printed an error */
>        }

ACK patches 1-7.

I made a comment about patches 8-11.

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.