Re: [Libguestfs] [PATCH 3/5] Move xml and xpath_helpers OCAML code to mllib

Pino Toscano
Thu, 05 Jan 2017 08:22:19 -0000

On Tuesday, 3 January 2017 11:18:54 CET Cédric Bosdonnat
wrote:
> To allow other pieces of code to process XML files easily, move the
> xml.ml* and xpath_helpers.ml* from v2v to mllib.
> ---

This seems mostly fine, with just code motion indeed.

> diff --git a/docs/C_SOURCE_FILES b/docs/C_SOURCE_FILES
> index 7fa7d0a67..7e4dbdb25 100644
> --- a/docs/C_SOURCE_FILES
> +++ b/docs/C_SOURCE_FILES
> @@ -390,4 +390,4 @@ utils/qemu-boot/qemu-boot.c
>  utils/qemu-speed-test/qemu-speed-test.c
>  v2v/domainxml-c.c
>  v2v/utils-c.c
> -v2v/xml-c.c
> +mllib/xml-c.c

This file should be sorted, and it can be updated automatically:
  $ rm docs/C_SOURCE_FILES
  $ make docs/C_SOURCE_FILES

Thanks,
--
Pino Toscano