Re: [Libguestfs] [PATCH] p2v: Inhibit power saving during the conversion.

Richard W.M. Jones
Tue, 25 Oct 2016 09:57:51 -0000

On Tue, Oct 25, 2016 at 11:37:17AM +0200, Pino Toscano
wrote:
> On Tuesday, 25 October 2016 10:16:42 CEST Richard W.M. Jones wrote:
> > > The rest of the libdbus-1 implementation looks correct, checking
with
> > > the API docs (and a bit the internals).  Maybe could be worth
using
> > > the glib-based interface for it (dbus glib or GDBus).
> >
> > Is there any particular advantage?  The low level API is pretty
> > horrible to use, but in the end it wasn't too much code.
>
> Mostly because of the above, the fact that's low-level, and that using
> the glib binding should integrate with the glib main loop.

We don't use the glib main loop for kernel-driven conversions
anyway, so seems like it's best to use the low-level API.

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.