Re: [Libguestfs] [PATCH 2/2] ruby: tests: Give each test class and method a unique name.

Pino Toscano
Fri, 10 Jun 2016 13:10:32 -0000

In data martedì 7 giugno 2016 22:35:33, Richard W.M. Jones ha
scritto:
> 'tc_410_close_event.rb' was not being run.  You could prove this by
> simply inserting "exit 1" into that test.
>
> The reason is unclear, but by renaming every class and method in the
> tests to be unique, this ensures the tests are run.
> ---

ruby/t/tc_410_close_event.rb:  def test_events
ruby/t/tc_420_log_messages.rb:  def test_events

This explains: all the tests have TestLoad as class name, and these two
tests have the same method name.  IMHO renaming just the class names
should be enough, but this patch is fine as well.

Thanks,
--
Pino Toscano