Re: [Libguestfs] [PATCH] perl: Don't embed API number in Sys::Guestfs.

Pino Toscano
Fri, 26 Feb 2016 10:54:05 -0000

On Thursday 25 February 2016 08:59:18 Richard W.M. Jones
wrote:
> It means you have to rerun `make -C perl clean ; make' every time you
> add an API, and is useless anyway.
> ---
>  generator/perl.ml | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/generator/perl.ml b/generator/perl.ml
> index 5250ce1..f11477b 100644
> --- a/generator/perl.ml
> +++ b/generator/perl.ml
> @@ -722,16 +722,17 @@ package Sys::Guestfs;
>  use strict;
>  use warnings;
>
> -# This version number changes whenever a new function
> -# is added to the libguestfs API.  It is not directly
> -# related to the libguestfs version number.
> +# This is always 1.0, never changes, and is unrelated to the
> +# real libguestfs version.  If you want to find the libguestfs
> +# library version, use $g->version.  If you want to test if
> +# APIs/parameters are present, use %%guestfs_introspection.
>  use vars qw($VERSION);
> -$VERSION = '0.%d';
> +$VERSION = '1.0';

Why don't we just put the libguestfs version as module version?
(doing the same in other bindings as well.)

--
Pino Toscano