Re: [Libguestfs] [PATCHv4 0/2] Introduce vfs_minimum_size API to get minimum filesystem size.

Richard W.M. Jones
Tue, 20 Oct 2015 16:35:52 -0000

On Tue, Oct 20, 2015 at 06:45:54PM +0300, Maxim Perevedentsev
wrote:
> Tried to make it in accordance with your comments.
>
> Difference to v1:
> Added reply_with_error where necessary.
> Changed name get_min_size -> vfs_min_size.
>
> Difference to v2:
> Changed name to vfs_minimum_size.
> Changed parsing to xstrtol + STR* macros where possible.
>
> Difference to v3:
> Decapitalize error messages.
>
> Maxim Perevedentsev (2):
>   New API: vfs_minimum_size
>   Include resize2fs_P into vfs_minimum_size.
>
>  daemon/Makefile.am   |  1 +
>  daemon/daemon.h      |  2 ++
>  daemon/ext2.c        | 62 ++++++++++++++++++++++++++++++++-----
>  daemon/fs-min-size.c | 49 +++++++++++++++++++++++++++++
>  daemon/ntfs.c        | 87
++++++++++++++++++++++++++++++++++++++++++++++++++++
>  generator/actions.ml | 19 ++++++++----
>  po/POTFILES          |  1 +
>  7 files changed, 207 insertions(+), 14 deletions(-)
>  create mode 100644 daemon/fs-min-size.c

Looks good to me.  I'm going to run some tests on it now.

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.