Re: [Libguestfs] [PATCH v5 0/2] RFE: journal reader in guestfish

Pino Toscano
Wed, 02 Sep 2015 10:13:32 -0000

Hi,

a general note on the patches: please make sure everything builds and
works after applying each patch. Otherwise, bisecting code or simply
checking each works is not possible.

In this specific case, patch #1 will not build, since fish/journal.h
is being created with code in patch #2, and won't work either, since
do_log_journal does not call the new code.

In data lunedì 31 agosto 2015 15:07:35, Maros Zatko ha
scritto:
> There seems to be a minor issue when user wants to run it through pager
(more)
> and wants cancel it. User will end up with stuck guestfish until
journal-view
> transfers all journal items.

An option could be hooking to the current SIGINT handling in fish.c,
and canceling the dump of journal entries.

> Output is configurable, it's the same format as virt-log has, since
both
> uses same code.
>
> Maros Zatko (2):
>   cat: move get_journal_field to fish/journal.c
>   fish: add journal-view command (RHBZ#988100)
>
>  cat/Makefile.am       |   1 +
>  cat/log.c             | 114 ++--------------------------------------
>  fish/Makefile.am      |   1 +
>  fish/journal.c        | 141
++++++++++++++++++++++++++++++++++++++++++++++++++
>  generator/Makefile.am |   6 ++-
>  generator/actions.ml  |  22 ++++++++
>  generator/journal.ml  |  97 ++++++++++++++++++++++++++++++++++
>  generator/main.ml     |   3 ++
>  8 files changed, 272 insertions(+), 113 deletions(-)
>  create mode 100644 fish/journal.c
>  create mode 100644 generator/journal.ml

Thanks,
--
Pino Toscano