Re: [Libguestfs] [PATCH v2 1/9] build: Remove ./configure --enable-valgrind-daemon.

Pino Toscano
Mon, 29 Jun 2015 17:17:04 -0000

In data giovedì 25 giugno 2015 15:56:53, Richard W.M. Jones ha
scritto:
> If you've ever tried to use this option, you'll know that it
didn't
> work well.  It broke random things (probably RHBZ#1020216, definitely
> RHBZ#1023630), and caused random failures generally, while often not
> actually failing when valgrind itself found problems.
>
> This does not remove the guestfs_internal_exit API.  That will
> instead be modified in a future commit.
> ---

I understand you don't like how it is currently done (and I might
agree); OTOH, some of the stuff here could still be used when trying to
valgrind the daemon within the appliance. Can you please leave this
commit aside for now, while I'm expermenting with a simplier valgrind
mode for the daemon?

Thanks,
--
Pino Toscano